quic: Resurrect prq svc queue #5481
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhinvasara-jumptrading
requested review from
nbridge-jump and
ripatel-fd
as code owners
akhinvasara-jumptrading
force-pushed
the
akhin/apply_svc_fix_2216
branch
from
408cf4f to
46d2c9d
Compare
|
@akhinvasara-jumptrading Kevin is working on a new fast nanosecond-based clock source. This allows us to retire fd_tickcount(). We might want to wait for that feature to arrive before merging this, because it eliminates the time scaling class of bugs. (No strong opinion on this though. If you think it's a good idea to merge this now, we shall do so.) |
akhinvasara-jumptrading
force-pushed
the
akhin/apply_svc_fix_2216
branch
7 times, most recently
from
68a9aa3 to
55400fd
Compare
This reverts commit 543e6f0fb72451eb6294f249c135322e05b8a50d.
reset next_timeout in svc_schedule
fix retx timeout ticks/ns issue
prep schedule in gen_frames
CRIT if svc_timer_cnt != active_conn_cnt
schedule idle_timeout from last_activity, not now
test_quic_conformance: update for service heap
fix test_quic_keep_alive
akhinvasara-jumptrading
force-pushed
the
akhin/apply_svc_fix_2216
branch
from
55400fd to
6a8de1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-applies the previously reverted commit to use a prq as the underlying data structure for the quic service queue. It also fixes the associated bugs that caused the initial reversion. This has been tested on both testnet and mainnet validators.
Probably worth looking at the commits separately - the first is just reverting the revert.